-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document Calyx RTL interface requirements #1843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampsyo
reviewed
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice; thanks for adding this!! I have a few writing/clarity suggestions throughout.
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
…calyx-interface-docs
@nathanielnrn merge when ready! Don't wait on my review |
rachitnigam
pushed a commit
that referenced
this pull request
Feb 16, 2024
* move docs into running-calyx dir * add interfacing.md documenting how to interface with RTL designs * remove old directory * update summary.md with interfacing.md * fix link * Update docs/running-calyx/interfacing.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Update docs/running-calyx/interfacing.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Update docs/running-calyx/interfacing.md Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu> * Polish and PR feedback --------- Co-authored-by: Adrian Sampson <asampson@cs.cornell.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
fud/
andinterpreter.md
into therunning-calyx/
directory, and adds aninterfacing.md
.Closes #1807.