Compaction Accounts for Continuous Assignments #1847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1767. Adds analysis so that compaction accounts for continuous assignments.
The analysis here is conservative, since it essentially treats all the continuous assignment as one big "block". In other words, any time a group affects the continuous assignments, then it will depend on any previous groups that affect on continuous assignments too. For example say we have
Then we detect an
A->C->E
dependence, in addition to the existing dependencies we already find by analyzing the groups/control.When I say a group "affects" a continuous assignment, I mean that the group reads or writes to a cell that continuous assignments read or write from (except in the case when the group and continuous assignments are just reading from the same cell; that's the only time that doesn't count).
Also, I checked and this doesn't affect the polybench results from our paper.