Merge Compaction and Promotion #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! One high-level suggestion from #1909 that I wanted to bubble up is defining a wrapper trait that manages the fixup stuff for passes that want to similar things to this pass. Might be worth doing in either this PR or another one if you think it makes sense. |
|
Bumping this for merge since I'm getting ready for #1902! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the compaction and promotion passes, which fixes #1909.
It also gets rid of the compaction pass.
You can pass
-x static-promotion:compaction=falseif you want to run just promotion, without compaction.Also, compaction has a very simple heuristic: if you can compact the schedule at all, then compaction occurs. In the future, I can see more complex heuristics.