Introduce calyx -> axi-wrapped-calyx fud2 path
#1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Sketch an example fud2 op * Fix typo --------- Co-authored-by: Adrian Sampson <adrian@radbox.org>
Testing locally on vec add, the hard-coded cocotb tests pass, meaning there is parity with the previous bash scripts
nathanielnrn
added
C: FPGA
rachitnigam
reviewed
Apr 3, 2024
yxi/axi-calyx/outputs/test.v
Outdated
There was a problem hiding this comment.
Let's not commit these test files to the repo
rachitnigam
reviewed
Apr 3, 2024
yxi/axi-calyx/remove-imports.py
Outdated
There was a problem hiding this comment.
This can be done with a sed command to remove all matching lines that start with import
30 tasks
nathanielnrn
commented
Apr 20, 2024
| let tmp_yxi = format!("{}.yxi", file_name); | ||
|
|
||
| //Get yxi file from main compute program. | ||
| //TODO(nate): Can this use the `yxi` operation instead of hardcoding the build cmd calyx rule with arguments? |
There was a problem hiding this comment.
I think this TODO was the only thing I wasn't sure about w.r.t best fud2 practices @sampsyo. Going to merge for now but can change this in a future PR.
nathanielnrn
force-pushed
the
axi-fud2
branch
5 times, most recently
from
24354b1 to
f0418a5
Compare
jiahanxie353
pushed a commit
to jiahanxie353/calyx
that referenced
this pull request
May 29, 2024
* merge Fud2 example (calyxir#1965) * Sketch an example fud2 op * Fix typo --------- Co-authored-by: Adrian Sampson <adrian@radbox.org> * axi-generator.py takes yxi file as argument (run python3 axi-generator.py input.yxi) * bash script for whole axi workflow * add input.yxi to axi-generator.py call in sim.sh * pass runt test? * diff between generated-axi-with-vec-add and fudaxi/cat.futil * to verilog should theoretically work * pass diff * axi.sh works on fixed-vec-add-w-imports * add futil to yxi operation to fud2 * almost working axi-gen * Update fud2 calyx -> axi-wrapped-calyx path. Testing locally on vec add, the hard-coded cocotb tests pass, meaning there is parity with the previous bash scripts * fud2 formatting * update fud2 snapshots * cleanup of extra files * formatting of axi-generator * make dedicated test dir for yxi * tidy up old comments * remove extra fixed-vec-add-w-imports.futil * add runt tests for fud2 invocation * update dockerfile to install fud2 attempt1 * dockerfile and fud2 attempt 2 --------- Co-authored-by: Elise Song <111922608+eys29@users.noreply.github.com> Co-authored-by: Adrian Sampson <adrian@radbox.org> Co-authored-by: eys29 <eys29@cornell.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This path allows "normal" calyx programs to be wrapped in a dynamically generated axi-wrapper with a
--through axi-wrappedinvocation offud2.This currently only works on programs using
@external, as opposed toref. See #1993.But since there is parity (barring the above) with the current, clunky bash script I think this it probably makes sense to merge this while #1993 gets worked on.