Generalize where wire_inliner looks for go and done ports.
#2114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opposed to hardcoded and signals
|
This lgtm, but makes me wonder: what would happen if someone tried to define a component with mulitple sets of Either way though, this is definitely better than what we have currently so I say merge. |
|
This PR will cause a panic. I imagine the behavior we want is to have all go/done signals OR'd together? I'm not sure how'd we best express this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
wire_inlinermore generally looks for ports marked with@goand@done. This has proved necessary when creating anaxi_seq_mem(#1733) that has it'scontent_enmarked with@goto conform to primitive memory signatures.