Update .expect interface (v2)
#2231
Conversation
There was a problem hiding this comment.
Awesome, congrats on getting on top of the CI stuff! And many thanks for taking us all the way and getting this done for all the different kinds of queues. I see no changes to the .sh file, so I assume any changes to that were temporary/experimental and could then be restored. Perfect, exactly as per plan :)
The last thing is that our error values of 10,000 and 20,000 are not long-term viable. We already knew this. I have asked on Zulip to see if we can get some guidance!
Meanwhile I have requested just a couple changes in comment-land. Even after you have completed those, please don't merge. Let's try and incorporate whatever feedback we get from Zulip and then we can merge.
|
Oh also, I showed Kabir a silly Github trick that you may also enjoy: cucapra/packet-scheduling#41 (comment) |
This PR makes progress towards #2170. It applies the new expect interface to all queues. These queues call queue_call, which has the updated code. Additionally, code for the oracles had to be updated, in particular the method operate_queue(). The value 2^32 - 2 is given to pushes, and the value 2^32 - 1 for errors generated from underflow or overflow.
This is the new version of #2227, because of branch environment issues.