Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy queue code #2261

Merged
merged 6 commits into from
Aug 21, 2024
Merged

Tidy queue code #2261

merged 6 commits into from
Aug 21, 2024

Conversation

anshumanmohan
Copy link
Contributor

@anshumanmohan anshumanmohan commented Aug 9, 2024 •
edited
Loading

This PR constitutes a full-court press, tidying up queue-related code all around.

Changes:

  • Use case more.
  • Remove instances of peek.
  • Remove the file ...queues/pifo.py, which has been subsumed by strict_and_rr_queues.py.
  • Black pass.
  • Whitespace fixes not addressed by Black.

@anshumanmohan anshumanmohan added the C: Queues One of the queue-style frontends label Aug 9, 2024
@anshumanmohan
Copy link
Contributor Author

@KabirSamsi once you've done your thing re: PCQ, please mark the PR ready for review and enable auto-merge!

@anshumanmohan anshumanmohan mentioned this pull request Aug 9, 2024
Open
9 tasks
@anshumanmohan anshumanmohan marked this pull request as ready for review August 21, 2024 15:50
@anshumanmohan anshumanmohan enabled auto-merge (squash) August 21, 2024 15:50
@anshumanmohan anshumanmohan merged commit 8d3708d into main Aug 21, 2024
18 checks passed
@anshumanmohan anshumanmohan deleted the tidy-queue-code branch August 21, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Queues One of the queue-style frontends
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anshumanmohan