Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

calyx-py: add line numbers to group enables, similar to Dhalia #2285

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Sep 18, 2024

@ayakayorihiro
Copy link
Contributor

Thanks a lot for this, it's great to see the source mapping here too!! We definitely need a indication of what file the code is coming from... but very exciting!!!!

@rachitnigam
Copy link
Contributor

@ekiwi what needs to be done to get this merged?

@ekiwi
Copy link
Contributor Author

ekiwi commented Oct 6, 2024

@ekiwi what needs to be done to get this merged?

There are mainly three blockers:

  1. We need to define a way to include the filename in addition to the line number.
  2. There is a bug where we end up with two line numbers for a single calyx invoke, I have to spend some time tracking that down.
  3. We need to spend some more time thinking about which calyx constructs should be annotated.

1+3 could be addressed in a future PR. 2 definitely has to be fixed before I am going to move this out of draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants