Seq #2346
Seq #2346
Conversation
| pub fn print_pc_string(&self) { | ||
| let current_nodes = self.pc.iter(); | ||
| let ctx = &self.ctx.as_ref(); | ||
| for node in current_nodes { |
There was a problem hiding this comment.
This & is unnecessary
| for node in current_nodes { | |
| let ctx = self.ctx.as_ref(); |
There was a problem hiding this comment.
I have no idea why this ended up on the wrong line
| @@ -56,6 +56,67 @@ impl ControlPoint { | |||
| false | |||
| } | |||
| } | |||
|
|
|||
| /// Returns a string showing the path from the root node to input node. | |||
| /// How to get context? | |||
There was a problem hiding this comment.
remove /// How to get context? also specify that the path is displayed in the
minimal metadata path syntax
| let path = SearchPath::find_path_from_root(self.control_node_idx, ctx); | ||
| let control_map = &ctx.primary.control; | ||
| let mut string_path = String::from(""); | ||
| let mut count = -1; |
There was a problem hiding this comment.
Prefer new over from with an empty &str
| let mut count = -1; | |
| let mut string_path = String::new(); |
There was a problem hiding this comment.
I guess my suggestion thing is just cursed, this also belongs on the line above
| if string_path.is_empty() { | ||
| string_path += "."; | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Hoist this out of the for loop and use in initialization of the string_path
| let mut count = -1; | ||
| let mut body = false; | ||
| let mut if_branches: HashMap<ControlIdx, String> = HashMap::new(); |
There was a problem hiding this comment.
I think this approach is fine and there's no need to change it here, but wanted
to flag the fact that if you zip the path with itself staggered by one
element, you can look at both the current node and the parent without needing
auxiliary structures. This can either be accomplished by processing the first
node specially or by appending a None value and mapping the parent field to an
option
Configured various files and edited the parser to print out nodes in the format we talked about.
Biggest function implemented was string_path in program_counter.rs