Naive number theoretic transform (NTT) example #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool! I suppose I should hook this into the Runt tests before merging. |
|
Never mind, looks like the examples aren't tested. (Maybe we should do that?) Anyway, I reproduced the correct outputs on my machine! So yes, will merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A successor to #247 where I started from scratch and used a very very naive quadratic NTT implementation. It is not a good NTT!! But at least I can understand what it's doing and check that the output is correct.
Speaking of which, the output is not currently correct. It produces 32 7s, which seems suspicious. So this is WIP until I figure out why.
See also nttstuff, where I have a couple of reference implementations and a data generator.