API error: improve error message #260
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need a minor change and will add testing. |
chantra
force-pushed
the
http_error_code
branch
2 times, most recently
from
c2ff4ad
to
c8bad71
Compare
|
added test against fixtures and a test-net test. |
Previously, a generic error would be returned: ``` Error: unexpected HTTP status 404 Not Found ``` This does not convey much information as to what happens. On the current version of dkregistry, one would hit this when trying to access s390x/ubuntu on registry-1.docker.io. This change specializes the error to surface more information as to why the error is happening as described in the OCI Distribution Specification: https://github.com/opencontainers/distribution-spec/blob/main/spec.md#error-codes In this specific case, the error would look like: ``` Error: Api Error: ((MANIFEST_UNKNOWN), message: OCI manifest found, but accept header does not support OCI manifests) Caused by: ((MANIFEST_UNKNOWN), message: OCI manifest found, but accept header does not support OCI manifests) ``` which clearly highlight that dkregistry does not support OCI manifest.
chantra
force-pushed
the
http_error_code
branch
from
c8bad71
to
8b2f432
Compare
|
@PratikMahajan any possibilities you look into this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, a generic error would be returned:
This does not convey much information as to what happens. On the current version of dkregistry, one would hit this when trying to access s390x/ubuntu on registry-1.docker.io.
This change specializes the error to surface more information as to why the error is happening as described in the OCI Distribution Specification: https://github.com/opencontainers/distribution-spec/blob/main/spec.md#error-codes
In this specific case, the error would look like:
which clearly highlight that dkregistry does not support OCI manifest.