Add support for authenticating against Azure Container Registry #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azure Container Registry returns the access token using the `access_token` field instead of the `token` field. With this commit, the token could be fetched from both fields Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
In contrast to ACR, Docker Hub responds with `token` and `access_token` which is not supported by the alias attribute provided by serde. That is why I came up with a dedicated struct deserializing both fields into an Option<String> the TryFrom<> implementation first tries to use the token property (as it was before this PR). If that is not present, it tries to take the access_token property. If both are missing, a corresponding error is thrown Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
|
Upon further testing I discovered that Docker Hub returns both fields |
Signed-off-by: Thorsten Hans <thorsten.hans@fermyon.com>
|
Renamed the struct from |
PratikMahajan
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #262 Azure Container Registry returns the access token using the
access_tokenfield instead of thetokenfield. With this commit, the token could be fetched from both fields