Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC-Review-1: Commonalities version #67

Closed
wants to merge 1 commit into from

Conversation

FabrizioMoggio
Copy link
Collaborator

Commonalities version added.

What type of PR is this?

  • documentation

What this PR does / why we need it:

To be aligned with Commonalities guidelines

Which issue(s) this PR fixes:

#66

@hdamker
Copy link
Contributor

hdamker commented Jul 23, 2024

@FabrizioMoggio: Is it by intention to go back to alpha.1 within this PR? Or is the change back from rc.1 to alpha.1 the result of using a wrong base for the PR?

The field x-camara-commonalities: 0.4.0 which is mentioned in the PR title seems not to be in yet.

Another observation in the documentation:

[**https://tim-api.developer.tim.it/callforwardingsignal**](https://tim-api\
    .developer.tim.it/callforwarding\signal)\

looks like a bad example ... first as it is company specific (example.com would be of help here), and second as the API name has to be call-forwarding-signal, see the server definition:

- url: "{apiRoot}/call-forwarding-signal/v0.2alpha1"
    variables:
      apiRoot:
        default: http://localhost:9091

@FabrizioMoggio
Copy link
Collaborator Author

sorry. uploaded the wrong version

@FabrizioMoggio
Copy link
Collaborator Author

uploaded the wrong version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants