Fall24 Review

[FabrizioMoggio]

• Commonalities version added
• Base URL removed
• version moved to wip
• Release notes removed
• Contact info removed

What type of PR is this?

• documentation

What this PR does / why we need it:

To be compliant with Commonalities

Which issue(s) this PR fixes:

#66
#69
#71
#70
#76

[hdamker]

@FabrizioMoggio: there is a general challenge with this PR - you have created already a r1.1 tag with the API Version 0.2.0-rc.1 which you can't and shouldn't change anymore (the tagged commit is 33f21b2).

Once a versioned package has been released, the contents of that version MUST NOT be modified. Any modifications MUST be released as a new version. (https://semver.org/#spec-item-3)

The way forward is to consider a second release candidate with API Version 0.2.0-rc.2 and r1.2 as tag (that will come with a new section within the changelog, update of README.md, checklist, ...). That should be created in a separate Release PR.

But I wouldn't already now create the second release candidate but wait for further feedback on the first release candidate and some more substantial fixes then just the formal ones. You can for example open a "scope" issue for the rc.2 (like Commonalities did in camaraproject/Commonalities#253

This current PR here which is fixing #66 and #69 should reset the version in the meantime to "wip" as there are changes to the YAML included which shouldn't be part of a release PR. But you can keep it also open for a while to collect more feedback on rc.1.

[chinaunicomyangfan]

LGTM

[hdamker]

Looks good from release management

[FabrizioMoggio]

Looks good from release management

Can I move forward with the Release Tag?

[hdamker]

Can I move forward with the Release Tag?

See #72 for next steps. Have only seen afterwards that that the changes for the release are spread across PRs.