-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare release r1.2 #91
Conversation
Moved new release to top Applied the CHANGELOG.md template to r1.2 Replaced links to issues with links to PRs Removed formal changes which are not relevant for API users
Removed comments from Design Guidelines (not meant to be in the YAML) Updated x-camara-commonalities to the current available version Updated version and server url Aligned server URL description with latest Commonalities guideline
Deleted obsolete file
Aligned "Comments" on left
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@hdamker Just one question about this sentence: "Special notes for reviewers: and especially on this section: "The merge commit of this PR will get tagged as the release r1.2." My problem is that in this PR the version is still: wip. I can not create a Release Tag. In my understanding the sequence is:
is this sequence correct? |
Set version and server url to the correct values for the second release candidate.
info.description: updated the "Authorization and authentication" section according to: #90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FabrizioMoggio You have already seen by 0b0b2f3 that I just missed to change the My intention was:
The change of the Auth section could have done also in a dedicated PR for the issue (which would have been merged before this one here). But I'm also fine with your commit 3b72d16 here. I updated the PR description ("Fixes ...") and the CHANGELOG.md.
Yes, and this is the release PR, hence it does the change to v0.2.0-rc.2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
I think that everything is fixed. Waiting for a final approval by @camaraproject/release-management_maintainers before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@FabrizioMoggio You are good to go ... I just asked @rartych for final view on the PR from release management perspective (as I didn't wanted to approve my own PR). |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
This is the release PR for r1.2.
Update of CHANGELOG.md
Update Call_Forwarding_Signal.yaml
Deleted obsolete README.md in API_Definitions
Cosmetic change within call-forwarding-signal-API-Readiness-Checklistst.md
Which issue(s) this PR fixes:
Fixes #72 #90
Special notes for reviewers:
The PR should be merged only after all issues within scope of #72 are resolved (especially #90) and after the PR got an approval by one of @camaraproject/release-management_maintainers. The merge commit of this PR will get tagged as the release r1.2.