Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api spec fixes from linter rules #137

Merged
merged 4 commits into from
Jan 30, 2024
Merged

Conversation

PedroDiez
Copy link
Collaborator

What type of PR is this?

  • correction

What this PR does / why we need it:

PR to fix some API spec format considerations from linter rules:

  • response codes between quotes marks
  • "status" within Error Info model is an integer, as per commonalities.

PR created over release-0.2.0 branch in order to incorporate to it before merging

Which issue(s) this PR fixes:

Fixes #126

@PedroDiez PedroDiez self-assigned this Jan 30, 2024
@PedroDiez PedroDiez added the correction API specification needs correction label Jan 30, 2024
@PedroDiez
Copy link
Collaborator Author

Going to close and generate a new one considering the linter rules output

@PedroDiez PedroDiez closed this Jan 30, 2024
@PedroDiez PedroDiez reopened this Jan 30, 2024
@PedroDiez
Copy link
Collaborator Author

Have make some tests but seems there is no way currently to modify "release" branch as current config

@PedroDiez
Copy link
Collaborator Author

Please @bigludo7, @rartych take a look to this PR first in order to merge and after that I will synchornize the release one:
#134

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PedroDiez
Copy link
Collaborator Author

I am merging this PR and going to trigger linter rules again to check the result

@PedroDiez PedroDiez merged commit 76ed3c4 into main Jan 30, 2024
@PedroDiez PedroDiez deleted the api_spec_fixes_from_linter_rules branch October 10, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction API specification needs correction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement use of linting rule set for Carrier Billing API
3 participants