Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API-design-guidelines - Issues 97&98 #123

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Jan 22, 2024

Updates in 8.Pagination, Sorting and Filtering

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #97 #98

Special notes for reviewers:

Changelog input

 release-note

Updates in 8.Pagination, Sorting and Filtering
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@shilpa-padgaonkar
Copy link
Collaborator

@gmuratk : Could you kindly review this PR for your raised issues 97 and 98?

@shilpa-padgaonkar
Copy link
Collaborator

@RubenBG7 @jordonezlucena : Could you kindly review this PR as code owners? Hopefully we can get this merged before the upcoming release.

Copy link
Collaborator

@RubenBG7 RubenBG7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of From TEF

@rartych rartych merged commit 5c844c1 into main Feb 5, 2024
@rartych rartych deleted the rartych-patch-1 branch June 11, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sorting & Filtering Optionality
6 participants