-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alignment_with_PR_198 #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was missing, so LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
for alignement with #198 note about expired token.
@PedroDiez and @bigludo7 Do we also want to align this to the PR #194 discussion and get rid of 415 error as well? |
I think it is already aligned Shilpa (let's see also Ludovic's view). My understanding:
|
@PedroDiez Yes, that's correct, for subscriptions it could still be a possible scenario.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
…into Alignment_with_PR_198
7df07b0
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Align template with #198
Which issue(s) this PR fixes:
Fixes #185 #153
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.