Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment_with_PR_198 #219

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Alignment_with_PR_198 #219

merged 3 commits into from
Jun 4, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented May 31, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Align template with #198

Which issue(s) this PR fixes:

Fixes #185 #153

Special notes for reviewers:

Changelog input

 release-note
- Add `ACCESS_TOKEN_EXPIRED` termination reason value
- Document `notificationsBearerAuth`

Additional documentation

This section can be blank.

docs

patrice-conil
patrice-conil previously approved these changes May 31, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was missing, so LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM
for alignement with #198 note about expired token.

@shilpa-padgaonkar
Copy link
Collaborator

@PedroDiez and @bigludo7 Do we also want to align this to the PR #194 discussion and get rid of 415 error as well?

@PedroDiez
Copy link
Collaborator Author

I think it is already aligned Shilpa (let's see also Ludovic's view). My understanding:

@shilpa-padgaonkar
Copy link
Collaborator

@PedroDiez Yes, that's correct, for subscriptions it could still be a possible scenario..

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@PedroDiez PedroDiez dismissed stale reviews from shilpa-padgaonkar and patrice-conil via 7df07b0 June 3, 2024 07:48
@rartych rartych merged commit 9bd83eb into main Jun 4, 2024
@rartych rartych deleted the Alignment_with_PR_198 branch October 9, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Common proposal to tackle subscription-based open issues.
5 participants