Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set relative links between commonalities documents #283

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

PedroDiez
Copy link
Collaborator

@PedroDiez PedroDiez commented Aug 12, 2024

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Set relative links for API design guidelines between Commonalities Documents
Documents identified to be covered:

  • API-design-guideliens.md (DONE)
  • Issue and PR template HowTo.md (DONE)
  • Linting-rules.md (DONE)

Which issue(s) this PR fixes:

Fixes #275

Special notes for reviewers:

Changelog input

 set relative links between commonalities documents

Additional documentation

This section can be blank.

docs

@rartych rartych added the correction correction in documentation label Aug 19, 2024
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on behalf of @patrice-conil for Orange team

Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@rartych rartych merged commit ca16bae into main Aug 21, 2024
@rartych rartych deleted the set_relative_links_between_commonalities_documents branch October 9, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
correction correction in documentation
Projects
None yet
4 participants