Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for boolean #336

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Nov 7, 2024

What type of PR is this?

  • enhancement/feature

What this PR does / why we need it:

Adds indications how to formulate filter criteria for boolean-valued attributes.
boolAttr=true&... and boolAttr=false&... is proposed in 8.3 of API Design Guidelines

Which issue(s) this PR fixes:

Fixes #130

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

Changelog input

Filtering for boolean values added to  API Design Guidelines.

Additional documentation

PedroDiez
PedroDiez previously approved these changes Nov 8, 2024
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych added documentation Improvements or additions to documentation Spring25 labels Nov 18, 2024
patrice-conil
patrice-conil previously approved these changes Nov 25, 2024
Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych dismissed stale reviews from patrice-conil and PedroDiez via 5af0f61 November 27, 2024 12:07
@rartych rartych requested a review from PedroDiez November 27, 2024 12:17
Copy link
Collaborator

@PedroDiez PedroDiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@patrice-conil patrice-conil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych merged commit a0cd134 into camaraproject:main Nov 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Spring25
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filtering for data type "boolean"
4 participants