Minor changes needed in API-design-guidelines.md for CloudEvents #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rartych
requested review from
shilpa-padgaonkar,
patrice-conil,
RubenBG7 and
jordonezlucena
as code owners
bigludo7
approved these changes
Nov 7, 2023
This was referenced Nov 8, 2023
editorial - remove 's' from subscriptionId
rartych
dismissed stale reviews from shilpa-padgaonkar and patrice-conil
via
9d0c598
eric-murray
approved these changes
Nov 13, 2023
bigludo7
reviewed
Nov 13, 2023
There was a problem hiding this comment.
@rartych as discussed today 3 sentences proposal for the subscription operation table. I was not able to edit the PR but just comment.
Seems that our discussion was aligned with @PedroDiez thought.
Notes about status codes for operations on subscriptions (SYNC/ASYNC) added.
|
@RubenBG7 @jordonezlucena Please review this PR as code owners. |
CloudEvents version (1.0.2) explicitly indicated
Editorial correction in subsection title in 3.1
eric-murray
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Certain minor points have been identified within the design guidelines that need to be changed for the CloudEvents content.
Some editorial changes for better readability added.
Which issue(s) this PR fixes:
Fixes #83
Special notes for reviewers:
Changelog input