-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated paths in CAMARA Connectivity Insights API.yaml #40
Conversation
Changed path names to new proposal per #24
Added the generic error schema
Corrected the Network Info insight model to show basic network info
Added stream separator to support redocly rendering
Tabs to spaces
Added operation IDs
should we consider moving application profiles into a separate yaml similar to how qos profiles is done in QoD? would like top hear everyone's thoughts on this. |
Good question - let's discuss on the call. |
@Kevsy have updated fixes for multiple issues as listed in the commit message as well as the discussion points of separating out the application-profiles and network-info into their own separate yaml files. requesting for your review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maheshc01 -
minor changes requested: policy -> profile throughout
...and just to confirm, there will be an additional connectivity-insights.yaml as well? (to answer the intent, 'how well can the network fulfil my application profile demand now and/or in future?)
I'm confused by this PR ... it says in the description "correction" but is actually a complete restructuring of the API(s) and a scope change of the Sub Project? Best practices is one issue, one PR. And restructuring of the API(s) should be best done without further changes coming from completely different topics at the same time. Otherwise reviewers don't have chance to follow it at all. Please have a look on https://github.com/camaraproject/Governance/blob/main/CONTRIBUTING.md and https://github.com/camaraproject/Governance/blob/main/ProjectStructureAndRoles.md. |
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Kevin Smith <Kevsy@users.noreply.github.com>
Changed path names to new proposal per #24
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Changes the path names per the discussion #24
Which issue(s) this PR fixes:
Fixes #39
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.