Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding configuration for Github Actions with linting ruleset #167

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

rartych
Copy link
Collaborator

@rartych rartych commented Mar 7, 2024

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

The changes follow the instructions in https://github.com/camaraproject/Commonalities/blob/main/documentation/API-linting-Implementation-Guideline.md

Which issue(s) this PR fixes:

Fixes #125

Special notes for reviewers:

Changelog input

Linting ruleset configured in Github Actions

Additional documentation

CAMARA API Linting Rules Documentation

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we have to set a merging order among the ongoing PRs to avoid conflicts. This one should go after the ones with fixes/enhancements, and #166

@jlurien jlurien self-requested a review April 8, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement use of linting rule set for Device Location API
3 participants