Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing plan for location verification #189

Merged
merged 16 commits into from
Jul 19, 2024
Merged

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Apr 24, 2024

What type of PR is this?

  • tests

What this PR does / why we need it:

Example of testing plan aligned with the guidelines being proposed in camaraproject/Commonalities#158.

Which issue(s) this PR fixes:

Fixes #208

Special notes for reviewers:

There are many comments embedded in the test plan to clarify and explain some scenarios. In some cases alternate syntax for the same functionality is used to illustrate the possibilities.

Some points are still open to discussion, such as the degree of specification of the testing plan.

Copy link

github-actions bot commented Apr 24, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 3 0 4.99s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.81s
✅ YAML yamllint 3 0 0.68s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

bigludo7
bigludo7 previously approved these changes Apr 29, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with @patrice-conil and work for Orange side.
Could be very helpful to provide an extract from that to answer camaraproject/Commonalities#127 in commonalities.

@jlurien
Copy link
Collaborator Author

jlurien commented May 3, 2024

Checked with @patrice-conil and work for Orange side. Could be very helpful to provide an extract from that to answer camaraproject/Commonalities#127 in commonalities.

Yes, I have to think how to align this with the work in Commonalities and the testing guidelines enhancement. I will be preparing some more detailed proposal towards the dedicated workshop.

@bigludo7
Copy link
Collaborator

bigludo7 commented Jun 3, 2024

@jlurien Accordingly to your proposal in Commonalities, this file name should location-verification.feature I guess.

@jlurien
Copy link
Collaborator Author

jlurien commented Jun 3, 2024

@jlurien Accordingly to your proposal in Commonalities, this file name should location-verification.feature I guess.

True, I have to update and align my own example with my own proposal :) I am trying to close first the discussion in the proposal

bigludo7
bigludo7 previously approved these changes Jun 18, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me
2 very minor typing errors

code/Test_definitions/location-verification.feature Outdated Show resolved Hide resolved
code/Test_definitions/location-verification.feature Outdated Show resolved Hide resolved
@jlurien
Copy link
Collaborator Author

jlurien commented Jul 19, 2024

@bigludo7 Wee need another explicit approval after the last fixes to merge the PR. Thanks

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit ed46e8a into main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Meta-release Fall24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test plan for Location Verification API
2 participants