-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing plan for location verification #189
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked with @patrice-conil and work for Orange side.
Could be very helpful to provide an extract from that to answer camaraproject/Commonalities#127 in commonalities.
Yes, I have to think how to align this with the work in Commonalities and the testing guidelines enhancement. I will be preparing some more detailed proposal towards the dedicated workshop. |
@jlurien Accordingly to your proposal in Commonalities, this file name should location-verification.feature I guess. |
True, I have to update and align my own example with my own proposal :) I am trying to close first the discussion in the proposal |
Version to vwip to be aligned with the yaml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for me
2 very minor typing errors
@bigludo7 Wee need another explicit approval after the last fixes to merge the PR. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
Example of testing plan aligned with the guidelines being proposed in camaraproject/Commonalities#158.
Which issue(s) this PR fixes:
Fixes #208
Special notes for reviewers:
There are many comments embedded in the test plan to clarify and explain some scenarios. In some cases alternate syntax for the same functionality is used to illustrate the possibilities.
Some points are still open to discussion, such as the degree of specification of the testing plan.