Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling when the requested geofence area cannot be covered #224

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jul 3, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Adds handling when the provided subscription area cannot be covered or is too small to receive any notifications.

Which issue(s) this PR fixes:

Fixes #198

@maxl2287 maxl2287 self-assigned this Jul 3, 2024
@maxl2287 maxl2287 added enhancement New feature or request Fall24 Meta-release Fall24 labels Jul 3, 2024
@maxl2287 maxl2287 marked this pull request as draft July 3, 2024 13:07
@maxl2287 maxl2287 marked this pull request as ready for review July 3, 2024 13:09
bigludo7
bigludo7 previously approved these changes Jul 3, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxl2287
Copy link
Contributor Author

maxl2287 commented Jul 3, 2024

@bigludo7 do you align with the TerminationReason?

@bigludo7
Copy link
Collaborator

bigludo7 commented Jul 3, 2024

@bigludo7 do you align with the TerminationReason?

I've raised a generic issue in commonalities (243). Here we have a specific one. I'm not sure about commonalities outcome so probably we can keep this one open to get team feedback, and in // check if we have a global direction from commonalities.

@maxl2287
Copy link
Contributor Author

maxl2287 commented Jul 3, 2024

In DeviceStatus we have a label waiting for commonalities.
Maybe we can also use such label here 🤔

jlurien
jlurien previously approved these changes Aug 27, 2024
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion

code/API_definitions/geofencing-subscriptions.yaml Outdated Show resolved Hide resolved
bigludo7
bigludo7 previously approved these changes Aug 27, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with José suggestion

Co-authored-by: Jose Luis Urien <jlurien@gmail.com>
@maxl2287 maxl2287 dismissed stale reviews from bigludo7 and jlurien via a2961f6 August 28, 2024 07:23
Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlurien jlurien merged commit a5ce526 into camaraproject:main Aug 28, 2024
1 check passed
@maxl2287 maxl2287 deleted the feature/geofencing-manage-unhandled-subscriptions branch August 28, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fall24 Meta-release Fall24 waitingForCommonalities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geofencing - Manage when telco is not able to manage geofencing on the requested area
3 participants