Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Location Verification API readiness checklist #226

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

jgarciahospital
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Checklist in MetaRelase for location-verification API to become stable (v1.0.0) based on current v0.3.0

Which issue(s) this PR fixes:

Fixes #220

@bigludo7
Copy link
Collaborator

How do you want to progress on this one @jgarciahospital ?
Do we approve it "as i"t and update it with following PR as asset are present? or do you prefer to keep the PR open and update on this one?

@jgarciahospital
Copy link
Collaborator Author

How do you want to progress on this one @jgarciahospital ? Do we approve it "as i"t and update it with following PR as asset are present? or do you prefer to keep the PR open and update on this one?

Good approach, I think we are following different strategy for this file in each API, but it can work. If you can merge, I'll update it now when uploading the requires user story, for instance.

Copy link
Collaborator

@jlurien jlurien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just the raw template, it has to be filled with the right values for Status and Comments. Moreover:

  • wrong file location: move the template to the API Sub Project repository in the home/code folder.
  • wrong file name: rename the file to include the prefix plus a dash, it must be: locatioon-verification-API-Readiness-Checklist.md

Remove also the instructions at the bottom. If the intention of the PR is to just add the templates without filling them, we could create files for the 3 APIs at once.

…cklist_location-verification-1.0.0.md to code/location-verification-API-Readiness-Checklist.md
@jlurien jlurien marked this pull request as draft July 16, 2024 07:45
@jlurien
Copy link
Collaborator

jlurien commented Jul 19, 2024

I will merge the PR so we can then add content to the template in subsequent PRs

@jlurien jlurien marked this pull request as ready for review July 19, 2024 12:02
@jlurien jlurien self-requested a review July 19, 2024 12:02
@jlurien jlurien merged commit 9d36047 into camaraproject:main Jul 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide API readiness checklist
3 participants