-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update location-verification-API-Readiness-Checklist.md #248
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
The PR is correct, but is there a specific reason that the user story is in Supporting Documents and not in API Documentation as with other APIs? But guess that doesn't matter too much. |
I guess no particular reason. should it be moved to API Doc? |
documentation/API_documentation/location-verification-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…iness-Checklist.md
User Story moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hdamker for | 9 | Test result statement | O | O | O | M |tbd| link | Do you know what is expected? Do we have any example from other APIs? Thanks |
I had same issue in OTP validation API. I've pinged @trehman-gsma for help - having a statement from GSMA that at least one implem has go thru the test could perhaps be an option? |
I'm not aware of an example that any of the APIs has achieved this line within this release cycle. Suppose we accept this in the TSC for this cycle and have also to define this criteria more precise. How it is described:
So not an implementation of a previous public version (which GSMA can have certified), but a (lab) implementation of the release candidate version from M3 with the test definition from the same version. The motivation was to reduce the risk that bugs in the API specification and inconsistencies between API and Test specification will be found only after the public release. But as the release candidates came late and the test definitions in many cases even later, there was no time to fulfil this criteria in the current cycle. |
I agree that is going to be hard to fully comply with this for this meta, due to the time constraints. |
Issue in RM to make them (and the TSC) aware makes sense for to me. The other APIs heading for stable have reported "N" as status, which is maybe more true, as there is no plan to get it done before the meta release. |
Created issue in RM: camaraproject/ReleaseManagement#89 |
documentation/API_documentation/location-verification-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…iness-Checklist.md
documentation/API_documentation/location-verification-API-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…iness-Checklist.md
Until a final resolution to the issue I have filled the row with "N" and a reference to the issue in the comments column |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
What this PR does / why we need it:
User Story for location-verification is now available