Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update location-verification.yaml #88

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Update location-verification.yaml #88

merged 1 commit into from
Aug 18, 2023

Conversation

jlurien
Copy link
Collaborator

@jlurien jlurien commented Aug 16, 2023

What type of PR is this?

  • correction

What this PR does / why we need it:

Adjust security scopes naming to api_name:[resource:]action, to be aligned with suggestions for #74

Which issue(s) this PR fixes:

n/a

Special notes for reviewers:

If OK, we should also adjust #55

Adjust security scopes naming to api_name:[resource:]action
@jlurien jlurien requested a review from bigludo7 as a code owner August 16, 2023 14:21
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @jlurien
I like the idea to standardize the security scope across all APIs but one comment: Is it only a DeviceLocation project decision or a global CAMARA one ? probably this is something that we should propose to Commonalities?

@jlurien
Copy link
Collaborator Author

jlurien commented Aug 16, 2023

Hello @jlurien I like the idea to standardize the security scope across all APIs but one comment: Is it only a DeviceLocation project decision or a global CAMARA one ? probably this is something that we should propose to Commonalities?

I think it is something pending to agree on consistent guidelines for security, securitySchemes and scopes across all WGs. There is already an issue on Commonalities for the scope format. One thing to review also is when to allow clientCredentials or authorizationCode. There is a debate about this in Identity WG.

To me it would be more flexible to define openidConnect as securityScheme and define scopes for it. In the end, OIDC is probably what we will use and it relies on a .well_known endpoint lo learn about the supported authentication flows

bigludo7 added a commit to bigludo7/DeviceLocation that referenced this pull request Aug 17, 2023
@jlurien jlurien merged commit 9cfd2eb into main Aug 18, 2023
@jlurien jlurien deleted the adjust-security-scopes branch December 12, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants