-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split /subscription
-endpoints into seperate APIs
#161
split /subscription
-endpoints into seperate APIs
#161
Conversation
Thanks @maxl2287 for the effort. |
@bigludo7 tbh I would handle this in a seperate PR 😄 Do you both agree? |
Works for me. |
ok for me. Yes, then then we need an additional PR for the subscriptions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me in order to move forward to the new model.
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
@sachinvodafone thanks for the findings! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK for me
@bigludo7 can we label this as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some typos... the big rework based on the new template will come anyway..
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
code/API_definitions/device-reachability-status-subscription.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…s-subscriptions.yaml
@bigludo7 I was needed to update the file-name to Please review again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to align with PR213 outcomes for the error linked to the device identifier but in order to not manage too complex PR I will prefer to merge this one and then raise another issue/PR to manage 213.
@maxl2287 @akoshunyadi @sachinvodafone WDYT?
- $ref: '#/components/parameters/x-correlator' | ||
security: | ||
- openId: | ||
- reachability-status:subscriptions:create |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the scope should be api-name:[resource:]action, so in this case device-reachabilty-status-subscriptions:create
(applies to other scopes in this PR too)
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Splits up the subscription-endpoints for reachability and roaming status into seperate YAML-files.
Which issue(s) this PR fixes:
Fixes #125