Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription-APIs: Alignment of errors with Commonalities #193

Conversation

maxl2287
Copy link
Contributor

@maxl2287 maxl2287 commented Jul 23, 2024

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature

What this PR does / why we need it:

Alignement of errors according to Commonalities guideline.

Which issue(s) this PR fixes:

Fixes #184

Changelog input

 release-note

- Aligned error scenarios list with Commonalities for subscription APIs

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Max, I've only review code/API_definitions/device-reachability-status-subscriptions.yaml and got a couple of comments for your consideration:

  • Probably 2 422 examples are missing
  • not sure why we should not remove 429 as it is part of the template finnally

Same comment should apply for device-roaming-status-subscriptions.yaml

@maxl2287
Copy link
Contributor Author

@bigludo7 updates are done.
Please review again :)

@maxl2287 maxl2287 requested a review from bigludo7 July 23, 2024 20:41
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)
Thanks Max.

@akoshunyadi
Copy link
Collaborator

I've noticed that there are quite a lot of differences to the template. Which has already differences to the design guidelines. :-)
Which means at the end, that we don't have standardized subscriptions in Camara.
Should we merge this PR as it is and create another one for the RC2 to match with the template, or keep it open for the RC2?

Btw. the last change of the template will be released in RC2 of the Commonalities Release, so currently we are conform with the RC1.

Copy link
Collaborator

@akoshunyadi akoshunyadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, regarding the error codes we should make one more round about the subscription template + implementations. For the RC1 it LGTM

@akoshunyadi akoshunyadi merged commit f089994 into camaraproject:main Jul 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fall24 RC1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align subscription-APIs with guidelines for error scenarios
3 participants