Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.description #228

Merged
merged 20 commits into from
Jan 23, 2025

Conversation

eric-murray
Copy link
Collaborator

Purpose:

  • documentation

What this PR does / why we need it:

Updates info.description with:

Which issue(s) this PR fixes:

Fixes #None
But helps with #212 and #222

Special notes for reviewers:

Will need to revisit once multi-SIM scenario handling is standardised

Changelog input

 release-note
 - Update info.description section for user identification and multi-SIM scenario handling

Additional documentation

None

bigludo7
bigludo7 previously approved these changes Dec 5, 2024
Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good for me. Indeed the multi-SIM could be updated later.

sachinvodafone
sachinvodafone previously approved these changes Dec 5, 2024
@eric-murray eric-murray dismissed stale reviews from sachinvodafone and bigludo7 via 35d4d3d December 18, 2024 10:22
@eric-murray
Copy link
Collaborator Author

I updated all YAMLs with text on multi-SIM scenario handling, and also the "identifying the device from the token" text for the device roaming API.

I had a question on identifying the device for the subscription APIs. Currently device is a required parameter of the Subscription Request. So does this mean that subscriptions can only be created with a 2-legged token? Or should device actually be optional?

@eric-murray
Copy link
Collaborator Author

@camaraproject/device-status_maintainers
info.description now updated for all APIs, and ready for review

@bigludo7
My question in the comment above is still open. Is it correct that a device identifier is required to create a subscription? If so, what are the rules when a 3-legged token is used to create the subscription?

@bigludo7
Copy link
Collaborator

Hi @eric-murray

Is it correct that a device identifier is required to create a subscription?

At least yes for the subscriptions for device status or for geofencing.

If so, what are the rules when a 3-legged token is used to create the subscription?

We have specified in the design guideline that: "If 3-legged access token is used, the POST and GET responses must not provide any device identifier.". Which mean that, like for non subscription API, we did not accept an identifier in the subscription body when we find the identifier from the token.

in the event-subscription-template.yaml you find the 422 UNNECESSARY_IDENTIFIE error specified.

@eric-murray
Copy link
Collaborator Author

@bigludo7
But if an explicit device identifier is always required, does that not prevent a 3-legged token from being used to create a subscription (because that will trigger the 422 UNNECESSARY_IDENTIFIER error)?

In any case, I raised the issue explicitly in Issue #241. If it is correct that an explicit device identifier is always required, I'd like to understand the 3-legged token scenario for the documentation.

@akoshunyadi
Copy link
Collaborator

@bigludo7 @sachinvodafone Are you OK with this PR?

@bigludo7
Copy link
Collaborator

@bigludo7 @sachinvodafone Are you OK with this PR?

Hi @akoshunyadi - Yes - We can continue the discussion with @eric-murray in #241

Copy link
Collaborator

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akoshunyadi akoshunyadi merged commit cf808ea into camaraproject:main Jan 23, 2025
2 checks passed
@eric-murray eric-murray deleted the eric-murray-patch-1 branch January 23, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants