-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update info.description #228
Update info.description #228
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good for me. Indeed the multi-SIM could be updated later.
35d4d3d
I updated all YAMLs with text on multi-SIM scenario handling, and also the "identifying the device from the token" text for the device roaming API. I had a question on identifying the device for the subscription APIs. Currently |
@camaraproject/device-status_maintainers @bigludo7 |
Hi @eric-murray
At least yes for the subscriptions for device status or for geofencing.
We have specified in the design guideline that: "If 3-legged access token is used, the POST and GET responses must not provide any device identifier.". Which mean that, like for non subscription API, we did not accept an identifier in the subscription body when we find the identifier from the token. in the event-subscription-template.yaml you find the 422 UNNECESSARY_IDENTIFIE error specified. |
@bigludo7 In any case, I raised the issue explicitly in Issue #241. If it is correct that an explicit device identifier is always required, I'd like to understand the 3-legged token scenario for the documentation. |
@bigludo7 @sachinvodafone Are you OK with this PR? |
Hi @akoshunyadi - Yes - We can continue the discussion with @eric-murray in #241 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose:
What this PR does / why we need it:
Updates
info.description
with:Which issue(s) this PR fixes:
Fixes #None
But helps with #212 and #222
Special notes for reviewers:
Will need to revisit once multi-SIM scenario handling is standardised
Changelog input
Additional documentation
None