Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Typo in response of CountryName & File name #30

Merged
merged 3 commits into from
Mar 7, 2023
Merged

Fix Typo in response of CountryName & File name #30

merged 3 commits into from
Mar 7, 2023

Conversation

ravindrapalaskar17
Copy link
Contributor

  1. Fix typo in Response of country Name
  2. Update the file name to> device-status.yaml

@ravindrapalaskar17
Fix Typo in response of CountryName & File name
ab983cf 
1. Fix typo in Response of country Name
2. Update the file name to> device-status.yaml
@ravindrapalaskar17
Copy link
Contributor Author

This PR is for fix the issue--> #27
@monamok @eric-murray please review

@ravindrapalaskar17 ravindrapalaskar17 mentioned this pull request Mar 3, 2023
Closed
@monamok
Copy link
Collaborator

monamok commented Mar 3, 2023

Thank you @ravindrapalaskar17.

@eric-murray
Copy link
Collaborator

@ravindrapalaskar17
An empty array is really [], not [ ]. As we are specifying the response and ideally all implementations will give the same response, it is probably better to be pedantic, so I made the change.

@ravindrapalaskar17
Copy link
Contributor Author

@ravindrapalaskar17 An empty array is really [], not [ ]. As we are specifying the response and ideally all implementations will give the same response, it is probably better to be pedantic, so I made the change.

Thanks @eric-murray

@ravindrapalaskar17
Copy link
Contributor Author

Can we merge this PR..?

eric-murray
eric-murray previously approved these changes Mar 7, 2023
View reviewed changes
@eric-murray eric-murray merged commit 29ac1f1 into camaraproject:main Mar 7, 2023
@eric-murray
Copy link
Collaborator

Merged as v0.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-murray eric-murray eric-murray approved these changes

@bigludo7 bigludo7 Awaiting requested review from bigludo7 bigludo7 is a code owner

@sachinvodafone sachinvodafone Awaiting requested review from sachinvodafone sachinvodafone is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ravindrapalaskar17 @monamok @eric-murray