-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation into API definition for release v0.2.0 (issue #18) #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have rendered the documentation using ReDoc.
Currently API Support mail and URL and Terms of Service leads to example.com
I guess in the final version it should direct to CAMARA own resources - I am not sure if they are available yet.
Similarly
externalDocs:
description: Project documentation at CAMARA
url: https://github.com/camaraproject/
Should rather point to https://camaraproject.org/home-devices-qod/
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Yes or maybe leave it as is. Is the same situation in other API projects... e.g. https://github.com/camaraproject/QualityOnDemand/pull/151/files Whatever we may agree in the future.
This is the same situation. But this is also aligned with other subprojects like QualityOnDemand. Actually, I think it is fine to point to the CAMARA project as a reference to external documentation. Because it can refer not only to Home Devices QoD documentation, but actually to Commonalities or any other general documentation in CAMARA. |
What type of PR is this?
What this PR does / why we need it:
Update API documentation according to v0.2.0 API version definition including changes from v0.1.0 release. The documentation will be added to the API definition as discussed in camaraproject/WorkingGroups#164. It was agreed that the CAMARA documentation should be embedded in the OAS definition and not separate. This will reduce the effort to maintain the documentation.
This PR is aligned to QualityOnDemand PR camaraproject/QualityOnDemand#151
Which issue(s) this PR fixes:
Fixes #18
Special notes for reviewers:
|
![Alt text](https://raw.githubusercontent.com/full_path)
info.description
:securitySchemes
descriptionsVisualizations tested with editor.swagger.io and app.redocly.com
Changelog input