Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation into API definition for release v0.2.0 (issue #18) #38

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented May 23, 2023

What type of PR is this?

  • documentation

What this PR does / why we need it:

Update API documentation according to v0.2.0 API version definition including changes from v0.1.0 release. The documentation will be added to the API definition as discussed in camaraproject/WorkingGroups#164. It was agreed that the CAMARA documentation should be embedded in the OAS definition and not separate. This will reduce the effort to maintain the documentation.

This PR is aligned to QualityOnDemand PR camaraproject/QualityOnDemand#151

Which issue(s) this PR fixes:

Fixes #18

Special notes for reviewers:

  • Multi-line descriptions formatted as |
  • External resources such as images and other docs are linked to the absolute paths in Github: ![Alt text](https://raw.githubusercontent.com/full_path)
  • Most part of the documentation is part of info.description:
    • I have renamed some sections: "Quick Start" to "Relevant terms and definitions", "API documentation, Details" to "API functionality"
    • Added section "Further info and support" as in legacy doc, with "(FAQs will be added in a later version of the documentation)". To be discussed if we maintain this as part of the spec or separately, or separately but linked in the spec.
  • " Authentication and Authorization" section is removed and content moved to the standard securitySchemes descriptions

Visualizations tested with editor.swagger.io and app.redocly.com

Changelog input

 CAMARA documentation is now embedded within the OAS definition, and not separate. 

monamok
monamok previously approved these changes May 30, 2023
@jpengar
Copy link
Collaborator Author

jpengar commented Jun 1, 2023

@rartych @bigludo7 Kindly reminder. If you could take a look at this, please.

Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rendered the documentation using ReDoc.

Currently API Support mail and URL and Terms of Service leads to example.com
I guess in the final version it should direct to CAMARA own resources - I am not sure if they are available yet.

Similarly

externalDocs:
  description: Project documentation at CAMARA
  url: https://github.com/camaraproject/

Should rather point to https://camaraproject.org/home-devices-qod/

Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
@jpengar
Copy link
Collaborator Author

jpengar commented Jun 5, 2023

Currently API Support mail and URL and Terms of Service leads to example.com
I guess in the final version it should direct to CAMARA own resources - I am not sure if they are available yet.

Yes or maybe leave it as is. Is the same situation in other API projects... e.g. https://github.com/camaraproject/QualityOnDemand/pull/151/files

Whatever we may agree in the future.

Similarly

externalDocs:
description: Project documentation at CAMARA
url: https://github.com/camaraproject/
Should rather point to https://camaraproject.org/home-devices-qod/

This is the same situation. But this is also aligned with other subprojects like QualityOnDemand. Actually, I think it is fine to point to the CAMARA project as a reference to external documentation. Because it can refer not only to Home Devices QoD documentation, but actually to Commonalities or any other general documentation in CAMARA.

@jpengar jpengar requested review from monamok and rartych June 5, 2023 09:38
@jpengar jpengar merged commit f18d653 into main Jun 6, 2023
@jpengar jpengar deleted the jpengar/update-spec-doc-issue-18 branch June 6, 2023 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v0.2.0 - Update API documentation according to v0.2.0 API version
3 participants