Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.2.0-rc.1 #177

Merged
merged 15 commits into from
Jul 11, 2024
Merged

Release 0.2.0-rc.1 #177

merged 15 commits into from
Jul 11, 2024

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Jun 20, 2024

What type of PR is this?

  • subproject management

What this PR does / why we need it:

This is "Release PR" for ICM Release 0.2.0-rc.1

Which issue(s) this PR fixes:

Related to #146

Special notes for reviewers:

  • The team agreed to proceed with a release candidate directly, bypassing the alpha release, given the stability and closed scope of the current state. See https://wiki.camaraproject.org/x/JYDcAQ for further details.
  • README.md - with the existing format in ICM there is no need to change anything.
  • CAMARA-AuthN-AuthZ-Concept.md is DEPRECATED and needs to be removed, but we should do it for the public release I think, not now for this release candidate "pre-release" (to avoid "breaking" the main branch now).
  • References in the released documents should always be links to a released version, not to the main branch. If the documents are released together, the links need to be updated at least within the release PR. But, same as previous point, we should do it for the public release, I think, and not now for this release candidate "pre-release" (to avoid "breaking" the main branch now).
  • CHANGELOG.md - Only the CHANGELOG file needs to be updated in the pre-release for now. Added all changes from the previous public release v0.1.0.

NEXT STEPS (edited by @hdamker):

NOTE: I will be on vacation for the next two weeks, I will need @AxelNennker, @sebdewet or other volunteers to continue this work for me. My goal is to merge this PR before I leave :) (fingercross)

Changelog input

ICM Release 0.2.0-rc.1

Additional documentation

https://wiki.camaraproject.org/display/CAM/Meta-release+Process#MetareleaseProcess-Milestoneactivities
https://wiki.camaraproject.org/display/CAM/Meta-release+Fall24

Copy link
Collaborator

@diegogonmar diegogonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good for me. Just suggest the change of all links:

  • the tag should be v0.2.0-rc.1 instead of v0.2.0-rc
  • we dropped the creation of "release" branches (especially for pre-releases), instead the links should go directly to the tag within the blob/tree.

Fingers crossed that my suggested links are correct after the tag v0.2.0-rc.1 is created ...

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
AxelNennker and others added 10 commits July 3, 2024 17:02
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Copy link
Collaborator

@diegogonmar diegogonmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the adjusts

@hdamker hdamker changed the title Release 0.2.0-rc Release 0.2.0-rc.1 Jul 3, 2024
@hdamker
Copy link
Collaborator

hdamker commented Jul 3, 2024

@AxelNennker
a) there are three "hidden" suggestions in my review to be committed to update the remaining links
b) I've updated the description of the PR slightly to align it with the versioning and release process guidelines

@tanjadegroot
Copy link

For the release process, please add @camaraproject/TSC_participants to the reviewers of this PR.

fix links

Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Copy link
Collaborator

@sebdewet sebdewet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@AxelNennker AxelNennker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdamker fixed the links and a accepted the suggestions.
Merging soon

@AxelNennker AxelNennker requested a review from hdamker July 4, 2024 09:17
Copy link
Collaborator

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @jpengar and @AxelNennker for the pull request. It looks good for me.

Within TSC today (draft minutes) we have decided to keep the release candidate PRs for Commonalities and ICM open until Wednesday, July 10th, for a final review including the TSC participants. So please wait with the merge until then.

@hdamker hdamker requested a review from a team July 4, 2024 10:40
@hdamker hdamker requested a review from a team July 4, 2024 17:08
Copy link
Collaborator

@shilpa-padgaonkar shilpa-padgaonkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@hdamker hdamker requested review from a team and rartych July 8, 2024 05:37
Copy link
Collaborator

@rartych rartych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be merged now.

@hdamker
Copy link
Collaborator

hdamker commented Jul 11, 2024

@AxelNennker @jpengar Can one of you please merge this PR and create the pre-release in GitHub before today's AHC on 16:00? If you can't for some reason I offer to take it.

@jpengar jpengar merged commit 40aaea5 into main Jul 11, 2024
@jpengar
Copy link
Collaborator Author

jpengar commented Jul 11, 2024

@AxelNennker @jpengar Can one of you please merge this PR and create the pre-release in GitHub before today's AHC on 16:00? If you can't for some reason I offer to take it.

@hdamker @AxelNennker @sebdewet Done. Please take a look to double check that everything is ok.

@hdamker
Copy link
Collaborator

hdamker commented Jul 11, 2024

@jpengar Thanks! Looks good to me. I would just recommend to update the README.md and mention there the release candidate explicitly, maybe even replacing the link to "latest public release" v0.1.0, as now the v0.2.0-rc.1 is more important.

@jpengar
Copy link
Collaborator Author

jpengar commented Jul 11, 2024

@jpengar Thanks! Looks good to me. I would just recommend to update the README.md and mention there the release candidate explicitly, maybe even replacing the link to "latest public release" v0.1.0, as now the v0.2.0-rc.1 is more important.

@hdamker @AxelNennker @sebdewet #179 please review.

@jpengar jpengar deleted the jpengar/release-020-rc branch August 29, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants