-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.2.0-rc.1 #177
Release 0.2.0-rc.1 #177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR looks good for me. Just suggest the change of all links:
- the tag should be v0.2.0-rc.1 instead of v0.2.0-rc
- we dropped the creation of "release" branches (especially for pre-releases), instead the links should go directly to the tag within the blob/tree.
Fingers crossed that my suggested links are correct after the tag v0.2.0-rc.1 is created ...
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the adjusts
@AxelNennker |
For the release process, please add @camaraproject/TSC_participants to the reviewers of this PR. |
fix links Co-authored-by: Herbert Damker <52109189+hdamker@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdamker fixed the links and a accepted the suggestions.
Merging soon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @jpengar and @AxelNennker for the pull request. It looks good for me.
Within TSC today (draft minutes) we have decided to keep the release candidate PRs for Commonalities and ICM open until Wednesday, July 10th, for a final review including the TSC participants. So please wait with the merge until then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be merged now.
@AxelNennker @jpengar Can one of you please merge this PR and create the pre-release in GitHub before today's AHC on 16:00? If you can't for some reason I offer to take it. |
@hdamker @AxelNennker @sebdewet Done. Please take a look to double check that everything is ok. |
@jpengar Thanks! Looks good to me. I would just recommend to update the README.md and mention there the release candidate explicitly, maybe even replacing the link to "latest public release" v0.1.0, as now the v0.2.0-rc.1 is more important. |
@hdamker @AxelNennker @sebdewet #179 please review. |
What type of PR is this?
What this PR does / why we need it:
This is "Release PR" for ICM Release 0.2.0-rc.1
Which issue(s) this PR fixes:
Related to #146
Special notes for reviewers:
README.md
- with the existing format in ICM there is no need to change anything.CAMARA-AuthN-AuthZ-Concept.md
is DEPRECATED and needs to be removed, but we should do it for the public release I think, not now for this release candidate "pre-release" (to avoid "breaking" the main branch now).CHANGELOG.md
- Only the CHANGELOG file needs to be updated in the pre-release for now. Added all changes from the previous public release v0.1.0.NEXT STEPS (edited by @hdamker):
- Create release v0.2.0 branch:release-0.2.0-rc
v0.2.0-rc.1
tag for the latest commit.NOTE: I will be on vacation for the next two weeks, I will need @AxelNennker, @sebdewet or other volunteers to continue this work for me. My goal is to merge this PR before I leave :) (fingercross)
Changelog input
Additional documentation
https://wiki.camaraproject.org/display/CAM/Meta-release+Process#MetareleaseProcess-Milestoneactivities
https://wiki.camaraproject.org/display/CAM/Meta-release+Fall24