Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace telco and operator by more general terms #201

Merged
merged 9 commits into from
Nov 11, 2024

Conversation

AxelNennker
Copy link
Collaborator

@AxelNennker AxelNennker commented Sep 11, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

Generalize the terms telco and operator to API provider

Which issue(s) this PR fixes:

Partly fixes 200

@AxelNennker
Copy link
Collaborator Author

Please add suggestions or approve

@jpengar
Copy link
Collaborator

jpengar commented Sep 16, 2024

Please add suggestions or approve

@AxelNennker Before we finish the review and merge this PR into main, we need to create another PR to update the README and CHANGELOG files and generate the r0.2.1 patch release as suggested by @herbert in #196 (comment).

@AxelNennker
Copy link
Collaborator Author

Followed @tanjadegroot review comments - mostly. Resolved conversations.
If I did not resolve a conversation, then please review my comment on that conversation and decide whether it can be resolved or not.

Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may need to make sure that the new DPV doc references are not broken again when we merge this PR. master branch already has a newer version of this document, updated for r0.2.1 with fixed DPV doc links. @AxelNennker You may want to consider merging your branch with master before merging the PR.

@AxelNennker AxelNennker merged commit 0b94650 into main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants