Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR #182 split - better english improvements (part 2 of 3) #213

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

jpengar
Copy link
Collaborator

@jpengar jpengar commented Oct 10, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

As discussed by the team in 11/09 WG call, in order to move things forward, we are going to split the content of PR #182 into three different PRs:

The WG concluded that it would be much easier to deal with if we separated the proposed changes in #182 into different PRs.

Which issue(s) this PR fixes:

N/A

Special notes for reviewers:

Further context in #182

CC @chrishowell

Changelog input

Improved document writing

Additional documentation

N/A

Copy link
Collaborator Author

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @chrishowell's writing suggestions are fine with me. 👍

@jpengar
Copy link
Collaborator Author

jpengar commented Oct 22, 2024

I invite WG participants to review and comment.
CC @AxelNennker @sebdewet

@jpengar jpengar requested a review from chrishowell October 22, 2024 10:17
@jpengar
Copy link
Collaborator Author

jpengar commented Nov 4, 2024

If there are no comments, I would like to merge this PR as it has been open for weeks, and even longer if we include the original PR #182. @sebdewet @AxelNennker

@jpengar jpengar merged commit 5fd4d95 into main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants