Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CAMARA-ICM-examples.md with CIBA examples #237

Merged
merged 11 commits into from
Jan 15, 2025

Conversation

sebdewet
Copy link
Collaborator

@sebdewet sebdewet commented Nov 26, 2024

What type of PR is this?

  • documentation

What this PR does / why we need it:

In CAMARA-ICM-examples.md, add CIBA examples as for Authorization code flow.

Which issue(s) this PR fixes:

Fixes #236

Special notes for reviewers:

optionnal question : In CIBA authentication request, do we define that client_assertion is mandatory ?

documentation/CAMARA-ICM-examples.md Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
@AxelNennker
Copy link
Collaborator

What is the status of this? I feel that we agree.
Could we close the open comments thus making clear that the comments were addressed?

  • "differ"
    @sebdewet Please consider committing my suggestion:

Please note: All values are example values and can be different from the values provided here.

  • returned scopes
    I would not include scopes in the response if they are identical to the ones requested
    Maybe remove them from all examples where requested scopes and returned scopes are the same?!
    The API consumer has to know if the scopes associated with the access token are different to what was requested, but if scopes are not part of the response then the API consumer can be sure that the requested scopes are associated with the access token

@eric-murray
Copy link
Collaborator

The CIBA /bc-authorize example should be explicitly labelled as an example of an unsigned request, and this PR would be a good place to correct that.

@jpengar
Copy link
Collaborator

jpengar commented Dec 17, 2024

@sebdewet, could you kindly review the comments? I believe we can reach a final agreement to close this PR, which is under Spring25 scope, by this week.

@sebdewet
Copy link
Collaborator Author

I updated the examples following your comments.

Co-authored-by: Diego Gonzalez Martínez <diegogonmar@gmail.com>
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully, with the suggestions below, we should be able to merge this PR. Could you check it? @sebdewet @AxelNennker @eric-murray

documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
sebdewet and others added 4 commits January 14, 2025 18:24
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
AxelNennker
AxelNennker previously approved these changes Jan 15, 2025
documentation/CAMARA-ICM-examples.md Show resolved Hide resolved
documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
jpengar
jpengar previously approved these changes Jan 15, 2025
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a minor change suggestion.

documentation/CAMARA-ICM-examples.md Outdated Show resolved Hide resolved
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
@sebdewet sebdewet dismissed stale reviews from jpengar and AxelNennker via d082f8e January 15, 2025 16:53
Copy link
Collaborator

@jpengar jpengar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jpengar jpengar merged commit 9da2553 into main Jan 15, 2025
1 check passed
@jpengar jpengar deleted the sdewet/Add-CIBA-Examples branch January 24, 2025 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add exemples full CIBA flow for CIBA in CAMARA-ICM-examples.md
5 participants