-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CAMARA-ICM-examples.md with CIBA examples #237
Conversation
What is the status of this? I feel that we agree.
|
The CIBA |
@sebdewet, could you kindly review the comments? I believe we can reach a final agreement to close this PR, which is under Spring25 scope, by this week. |
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
I updated the examples following your comments. |
Co-authored-by: Diego Gonzalez Martínez <diegogonmar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully, with the suggestions below, we should be able to merge this PR. Could you check it? @sebdewet @AxelNennker @eric-murray
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just a minor change suggestion.
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
What type of PR is this?
What this PR does / why we need it:
In CAMARA-ICM-examples.md, add CIBA examples as for Authorization code flow.
Which issue(s) this PR fixes:
Fixes #236
Special notes for reviewers:
optionnal question : In CIBA authentication request, do we define that client_assertion is mandatory ?