-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CAMARA-ICM-examples.md with CIBA examples #237
base: main
Are you sure you want to change the base?
Conversation
What is the status of this? I feel that we agree.
|
The CIBA |
@sebdewet, could you kindly review the comments? I believe we can reach a final agreement to close this PR, which is under Spring25 scope, by this week. |
Co-authored-by: Jesús Peña García-Oliva <jesus.penagarcia-oliva@telefonica.com>
I updated the examples following your comments. |
} | ||
``` | ||
In this example, scopes differs from the one defined in the /authorize. If scopes are identical in /authorize and in the successful response, parameter scope isn't returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this example, scopes differs from the one defined in the /authorize. If scopes are identical in /authorize and in the successful response, parameter scope isn't returned. | |
In this example, scopes differ from the one defined in the /authorize. If scopes are identical in /authorize and in the successful response, parameter scope may not be returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest change to may not be returned in order to not mandate an specific behavior in server. OAuth defines as optional when identical, so server can still return scopes in that case
What type of PR is this?
What this PR does / why we need it:
In CAMARA-ICM-examples.md, add CIBA examples as for Authorization code flow.
Which issue(s) this PR fixes:
Fixes #236
Special notes for reviewers:
optionnal question : In CIBA authentication request, do we define that client_assertion is mandatory ?