-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Agreed conclusion statement about auth method in Auth Code Flow #253
Agreed conclusion statement about auth method in Auth Code Flow #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me too, thank you!
A question to clarify: After this is merged the following request is still valid, right? Note the "prompt=consent".
|
@AxelNennker But the API provider could still ignore the request to prompt for in-band end user consent if the legal basis for processing the request did not require it. The API consumer cannot force the API provider to seek end user consent when that is not required. Prompting a fraudster to approve a SIM Swap check would defeat the purpose of that API. |
I don't think consent collection started by a request with "prompt=consent" is in-band. You are right regarding sim-swap, my mistake. I copied the example from our examples document and added prompt=consent. We have this template text:
I assume, that in some legislation for sim-swap the end-user probably does not have a right to opt-out. I agree that opting-out somewhat defeats the purpose of the sim-swap API but API Providers have to follow the law and if the law grants the users the right to opt-out then we have to implement that. Whether the API makes sense is our problem.
Example with fictional API where users can exercise their rights:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use API provider instead of operator
Side note off-topic: @hdamker says that our repos should dismiss code-owner-approvals if an PR is changed. Non-code-owner approvals are untouched. |
This PR should be a mere formality, as the agreement on the issue itself has already been concluded. The purpose of this PR is to implement the conclusion that has already been reached. The PR does not mention the 'prompt' parameter, nor does it define anything beyond it. @shilpa-padgaonkar Could you please review it? |
The proposed text uses the term "in-band", but without definition. I had assumed "in-band" meant the mechanism specified here. If that is not correct, "in-band" should be defined, or replaced with a reference to that diagram. Regarding purposes for which the legal basis is "opt-out" consent, if an end user has not opted-out, then they have consented, and no consent confirmation is required for the API execution to proceed. They must (somehow) be made aware that they have the right to opt-out, and there must be a mechanism to allow that, but that does not have to be a pop-up on their phone saying "You have the right to opt-out from this application requesting your personal information. Would you like to opt-out now?". |
A little broadly, as a tenet, I'm thinking..
I realize it is not a specific statement, but it might help us in looking at fields like prompt, login_hint etc. no? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What type of PR is this?
What this PR does / why we need it:
This PR includes a statement explaining the conclusion reached in #215 in the profile document as part of the Spring25 meta-release to make it 100% clear. As agreed here.
Which issue(s) this PR fixes:
Fixes #215
Special notes for reviewers:
N/A
Changelog input
Additional documentation
N/A