Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update endpoint description to reflect all use cases #138

Conversation

fernandopradocabrillo
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • documentation

What this PR does / why we need it:

Improve endpoint documentation to reflect the functionality and all possible usecases as well as when idDocument related errors are returned.
Updates derive from discussion on #135

Which issue(s) this PR fixes:

Fixes #135

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

GillesInnov35
GillesInnov35 previously approved these changes Aug 20, 2024
Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@GillesInnov35
Copy link
Collaborator

@fernandopradocabrillo , at Orange idDocument field is not currently proposed in the match identity API. but I understand that it is a second level of control of identity for some providers.
I think that idDocument field should be associated to a documentType (according to what is specifiedin partyManagement TMF API).
I read few comments concerning a list document type, it would be interesting to work on this point .
BR
Gilles

Add 'in those cases' between 'This means that' and 'if the value of idDocument is not provided, to make the case clear and make it aligned with the line 76.
@ToshiWakayama-KDDI
Copy link
Collaborator

Hi @GillesInnov35 , @fernandopradocabrillo ,

I have just updated the proposal to add 'in those cases' to line 24, to make it aligned with line 76.

Hope this is OK, and I would like Gilles to approve this PR again.

Thanks.
Toshi

Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ToshiWakayama-KDDI ToshiWakayama-KDDI merged commit 6419f4f into camaraproject:main Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[KYC Match] Which fields are meant to be used for identification of the mobile phone user?
3 participants