-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should postal code include country identification #7
Comments
My point is: for me, as a Telco Operator in one country and exposing the API, my service endpoint will receive a call to this API only if the request is for me, and I just have to apply the parameters in the request to the country I am operating on. It is assumed that there is a previous mechanism to route the request to the corresponding operator. |
With roaming and federation it makes sense to add CountryName |
Just to try to have content to document our conversation this morning: We are trying to follow the principles of simplicity for the user and data minimization:
This said, it's true that there are scenarios where including de country name would help the Developer/Service Provider avoid mistakes. But this would be based on including a parameter to "double check" the information they are providing in the request, and it wouldn't make sense to add parameters in any API just to double check (data minimization). So, we agree that it is very necessary to have a good documentation to make the Developer aware that the postal code will be processed by the telco operator responsible for that user assuming that the postal code is for the country where the telco operator operates. Anyway, this comment is probably missing other scenarios or causes of mismatches between both parameters... |
Currently postal code is not included in the proposed common definition of Area type: camaraproject/Commonalities#315 . |
Problem description
Postal code is not unique: for example 31000 is Pamplona in Spain and Toulouse in France.
In most cases the country can be derived from the phone number, but there can be other more sophisticated cases.
Making postal code unique should help to detect error API calls.
Possible evolution
Geographical coordinates are unique, the country property can be added to the postal code to make it unique like in https://github.com/camaraproject/DeviceStatus/blob/main/code/API_definitions/device-roaming-status.yaml
Alternative solution
Additional context
The text was updated successfully, but these errors were encountered: