Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assumptions to use the API with postalCode but without countryName #15

Conversation

javier-carrocalabor
Copy link
Contributor

What type of PR is this?

  • documentation

What this PR does / why we need it:

The included supporting document explains the assumptions to be considered when using the API including the postalCode parameter in the request, and being aware that there is no parameter specifiying the countryName.

Which issue(s) this PR fixes:

Fixes #7

Special notes for reviewers:

N/A

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Copy link

CLA Not Signed

Copy link

@FabrizioMoggio FabrizioMoggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I appreciate such a documentation very much. I will have it checked internally and, if required I can propose some modification later. For now I approve. Nice work.

@fernandopradocabrillo fernandopradocabrillo merged commit c4e1463 into camaraproject:main Nov 21, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should postal code include country identification
3 participants