Include initial proposal for Most Frequent Location API - Telefónica #6
Conversation
fernandopradocabrillo
requested review from
chinaunicomyangfan and
FabrizioMoggio
as code owners
fernandopradocabrillo
changed the title
| minimum: -180 | ||
| maximum: 180 | ||
| example: 7.10066 | ||
| PostalCode: |
There was a problem hiding this comment.
To avoid ambiguity the country property should be added to the postal code like in https://github.com/camaraproject/DeviceStatus/blob/main/code/API_definitions/device-roaming-status.yaml
CountryName:
description: The ISO 3166 ALPHA-2 country-codes of mapped to mobile country code(MCC). If there is mapping of one MCC to multiple countries, then we have list of countries. If there is no mapping of MCC to any country, then an empty array [] shall be returned..
type: array
items:
type: string
In most cases the country can be derived from the phone number, but there can be other more sophisticated cases.
The error responses should also cover situations like not recognized country name
There was a problem hiding this comment.
In the Device Status API, the property 'CountryName' is used in the response to return roaming specific information in the 'retrieve' operation. I don't see a clear motivation to include 'CountryName' here as an input, since when an operator receives a request for Most Frequent Location, the operator will look for the phone number in the country where it received the request.
Could you please give example of the cases where an operator can receive a request and it cannot decide what country is the request referring to?.
There was a problem hiding this comment.
this looks very good to me
Some text in info.desciption about consent management according to the CAMARA guidelines is missing. Anyway the current agreed text is for Fall24 APIs and maybe it can be updated in future meta releases. This can further discussed in the group and, if required, added in a further release.
|
Hi @FabrizioMoggio! I included @rartych comment on version and your review ahs been dismised. Can you please approve again so I can merge? Thanks! |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Initial code proposal from Telefónica for the Most Frequent Location API in order to set a base to start disucussions
Which issue(s) this PR fixes:
Fixes #5
Changelog input