-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release of API version 1.0.0-rc.1 #74
Conversation
Update CHANGELOG.md for v1.0
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
@bigludo7 The CHANGELOG.md should be updated as part of the release PR. I suppose you plan to do first the pre-release with the release candidate of v1.0.0. The release tag would be r1.1, the title in changelog be "r1.1 - rc", the API Version 1.0.0-rc.1. The PR should also change the version and base path within the YAML at the same time and do the final updates within the API Readiness Checklist. For the CHANGELOG entry there is a template available within CHANGELOG_TEMPLATE.md. Contentwise: I wouldn't call the stable release a "patch release". It will be just the first stable release (and here the release candidate of it). The reference to the changes within v0.5.0 don't help, as there were nothing documented ;-( I created a "draft release" with GitHub to see the relevant changes since v0.5.0, I suppose the following PRs should be mentioned, but reformulated and sorted into the categories:
(plus the ones which are still open) New Contributors
Full Changelog: v0.5.0...r1.1 I'm on vacation the next days, but the Release Management team (e.g. Tanja) can help if needed. |
Removed termsOfService and contact fields Fixed servers
documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
Thanks a lot @hdamker for the help ! |
@bigludo7 I approved the changes as they are working as expected (GitHub does not care about upper/lower case in the repository name). But the repository name is now "OTPValidation", not "OTPvalidation" ... |
Please add @camaraproject/release-management_maintainers if ready for final review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bigludo7 Very minor comments from the final review done in context of camaraproject/ReleaseManagement#56
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of the file should be one-time-password-sms-API-Readiness-Checklist.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done :)
documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
documentation/API_documentation/OTPvalidationAPI-Readiness-Checklist.md
Outdated
Show resolved
Hide resolved
…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
…cklist.md Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
…-password-sms-API-Readiness-Checklist.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from ReleaseManagement view - suppose we are done here.
@fernandopradocabrillo the PR still needs a codeowner review before it can be merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hdamker sorry for the late review
LGTM
@fernandopradocabrillo the PR can be merged and the release created. Let me know if you need support here. |
@fernandopradocabrillo there seem to be no additional comments. Can you please merge the PR and create the release? |
Sure! Sorry I didn't see the notification |
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Generation of first release-candidate for OTPValidationAPI
This first release candidate r1.1 contains the definition and documentation of the release-candidate of the OTPValidation API v1.0.0-rc.1.
Which issue(s) this PR fixes:
Fixes
Special notes for reviewers:
Changelog input
Additional documentation
This section can be blank.