Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release of API version 1.0.0-rc.1 #74

Merged
merged 38 commits into from
Aug 7, 2024
Merged

Conversation

bigludo7
Copy link
Collaborator

@bigludo7 bigludo7 commented Jul 12, 2024

What type of PR is this?

Add one of the following kinds:

  • documentation
  • subproject management

What this PR does / why we need it:

Generation of first release-candidate for OTPValidationAPI

This first release candidate r1.1 contains the definition and documentation of the release-candidate of the OTPValidation API v1.0.0-rc.1.

Which issue(s) this PR fixes:

Fixes

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Update CHANGELOG.md for v1.0
Copy link

github-actions bot commented Jul 12, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 1.64s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY secretlint yes no 0.68s
✅ YAML yamllint 1 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@hdamker
Copy link
Contributor

hdamker commented Jul 13, 2024

@bigludo7 The CHANGELOG.md should be updated as part of the release PR. I suppose you plan to do first the pre-release with the release candidate of v1.0.0. The release tag would be r1.1, the title in changelog be "r1.1 - rc", the API Version 1.0.0-rc.1. The PR should also change the version and base path within the YAML at the same time and do the final updates within the API Readiness Checklist.

For the CHANGELOG entry there is a template available within CHANGELOG_TEMPLATE.md.

Contentwise: I wouldn't call the stable release a "patch release". It will be just the first stable release (and here the release candidate of it). The reference to the changes within v0.5.0 don't help, as there were nothing documented ;-(

I created a "draft release" with GitHub to see the relevant changes since v0.5.0, I suppose the following PRs should be mentioned, but reformulated and sorted into the categories:


(plus the ones which are still open)

New Contributors

Full Changelog: v0.5.0...r1.1


I'm on vacation the next days, but the Release Management team (e.g. Tanja) can help if needed.

@bigludo7 bigludo7 changed the title Update CHANGELOG.md for v1.0 Release 1.0.0-rc.1 Jul 16, 2024
@bigludo7 bigludo7 added subproject management Indicating issues with subproject repository or release management process Fall24 Fall 24 Meta release labels Jul 16, 2024
@bigludo7 bigludo7 self-assigned this Jul 16, 2024
@bigludo7 bigludo7 marked this pull request as draft July 16, 2024 10:37
@bigludo7
Copy link
Collaborator Author

Thanks @hdamker
This is very helpful. I have rename the issue in order to tackle here the release candidate. Once PR #73 solve i will in this PR add the -rc yaml. I will also work here for the readme file.

Hope I'm on the right way

@bigludo7 bigludo7 changed the title Release 1.0.0-rc.1 Release of API version 1.0.0-rc.1 Jul 19, 2024
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@bigludo7
Copy link
Collaborator Author

I did another review considering a) the proposed renaming of the repository in #75 b) that the actual API is one-time-password-sms, not "OTP Validation API"

I did not proposed all changes within the generated links ... they will continue to work after the renaming.

Thanks a lot @hdamker for the help !

@hdamker hdamker self-requested a review July 25, 2024 11:36
hdamker
hdamker previously approved these changes Jul 25, 2024
@hdamker
Copy link
Contributor

hdamker commented Jul 25, 2024

@bigludo7 I approved the changes as they are working as expected (GitHub does not care about upper/lower case in the repository name). But the repository name is now "OTPValidation", not "OTPvalidation" ...

@hdamker
Copy link
Contributor

hdamker commented Jul 25, 2024

Please add @camaraproject/release-management_maintainers if ready for final review.

@bigludo7 bigludo7 requested a review from a team July 25, 2024 12:25
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bigludo7 Very minor comments from the final review done in context of camaraproject/ReleaseManagement#56

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the file should be one-time-password-sms-API-Readiness-Checklist.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :)

bigludo7 and others added 3 commits July 26, 2024 09:32
…cklist.md

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
…cklist.md

Co-authored-by: Herbert Damker <herbert.damker@telekom.de>
@bigludo7 bigludo7 requested a review from hdamker July 26, 2024 07:36
@hdamker hdamker requested a review from a team July 26, 2024 07:42
Copy link
Contributor

@hdamker hdamker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from ReleaseManagement view - suppose we are done here.

@fernandopradocabrillo the PR still needs a codeowner review before it can be merged

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hdamker sorry for the late review

LGTM

@hdamker
Copy link
Contributor

hdamker commented Jul 31, 2024

@fernandopradocabrillo the PR can be merged and the release created. Let me know if you need support here.

@hdamker
Copy link
Contributor

hdamker commented Aug 7, 2024

@fernandopradocabrillo there seem to be no additional comments. Can you please merge the PR and create the release?

@fernandopradocabrillo
Copy link
Collaborator

@fernandopradocabrillo there seem to be no additional comments. Can you please merge the PR and create the release?

Sure! Sorry I didn't see the notification

@fernandopradocabrillo fernandopradocabrillo merged commit 9f66894 into main Aug 7, 2024
1 check passed
@bigludo7 bigludo7 deleted the addChangelog.md branch August 23, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fall24 Fall 24 Meta release subproject management Indicating issues with subproject repository or release management process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants