Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed one-time-password-sms.yaml after megalinter check #53

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

bigludo7
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Fixed issues identified by MegaLinter check

Which issue(s) this PR fixes:

Fixes #52

Special notes for reviewers:

Looking also for Rafal for check (https://github.com/rartych )

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

@rartych
Copy link
Contributor

rartych commented Apr 18, 2024

I am afraid one more "trailing space" is hiding in line 223->228:
one-time-password-sms:send-validate: Permission to send OTP by SMS and to validate it

Copy link
Collaborator Author

@bigludo7 bigludo7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed trailing space in line 228
Thanks @rartych :)

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit 82d5368 into main Apr 18, 2024
@bigludo7 bigludo7 deleted the bigludo7-patch-1 branch April 18, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application of linting rules
3 participants