-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate API code and align with commonalities (meta-release item 1-2-3) #38
Comments
Hello @jgarciahospital This is not a big change but as we're close to the deadline this is tricky. See here the guidance |
I think here is asynchronous response, so I am not sure if guidelines related to event notification should be applied. |
I think as this is the same concept (use an url) we should use same attribute 'name'for developer's sake. But I got your point @rartych that this is not subscription. If you consider this is not an issue to commonalities v0.4 this is fine for me. |
As proposed in the #44: Making one additional review we find that QoD API suffered similar issue and finally they made the alignement (this Issue & PR summarizes). So, just for aligning with https://github.com/camaraproject/Commonalities/blob/main/documentation/API-design-guidelines.md#instance-based-implicit-subscription, let me propose to roll back to initial plan and:
|
The text was updated successfully, but these errors were encountered: