Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment of notification web hook to CloudEvent subscription model #332

Closed
hdamker opened this issue Aug 2, 2024 · 1 comment · Fixed by #335
Closed

Alignment of notification web hook to CloudEvent subscription model #332

hdamker opened this issue Aug 2, 2024 · 1 comment · Fixed by #335
Assignees
@maxl2287
Labels
correction correction in documentation or alignment with commonalities Fall24 Relevant for maintenance of Fall24 release

Comments

@hdamker
Copy link
Collaborator

hdamker commented Aug 2, 2024

Problem description

Commonalities 0.4.0 introduced the CloudEvent subscription model with 'sink' and 'sinkCredentials' instead of 'notificationUrl' and 'notificationAuthToken', including the needed schema, within chapter 12.1 of the API Design Guidelines.
quality-on-demand uses implicit subscription for QoS Session and must be aligned for the Fall24 release.

Expected behavior

Align quality-on-demand API with the changes introduced by camaraproject/Commonalities#198 ff.
Change org.camaraproject.qod.v0.qos-status-changed -> org.camaraproject.quality-on-demand.v0.qos-status-changed

Alternative solution

Additional context

#299 has to be adapted accordingly
@hdamker hdamker changed the title Alignment of notification Alignment of notification web hook to CloudEvent subscription model Aug 2, 2024
@hdamker hdamker added correction correction in documentation or alignment with commonalities Fall24 Relevant for maintenance of Fall24 release labels Aug 2, 2024
This was referenced Aug 2, 2024
Closed
Merged
@hdamker hdamker assigned hdamker and maxl2287 and unassigned hdamker Aug 5, 2024
@maxl2287 maxl2287 mentioned this issue Aug 5, 2024
Merged
jlurien added a commit to jlurien/QualityOnDemand that referenced this issue Aug 5, 2024
@jlurien
Update qod-provisioning.yaml
360bcaa 
- Updated implicit subscriptions model with Commonalities, issue camaraproject#332
- Error examples aligned with Commonalities (removed summary and some messages updated)
@jlurien
Copy link
Collaborator

jlurien commented Aug 5, 2024 •
edited
Loading

@hdamker/@maxl2287 I have just updated QoD provisioning to the new formar (sink + sinkCredential), adjusting also some descriptions in info. I think it can be replicated to quality-on-demand as it is.
I have corrected also one thing I think it is not right in the artifact and open the corresponding issue in Commonalities: camaraproject/Commonalities#271

@jlurien jlurien mentioned this issue Aug 5, 2024
Merged
This was referenced Sep 5, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxl2287 maxl2287

Labels
correction correction in documentation or alignment with commonalities Fall24 Relevant for maintenance of Fall24 release
Projects
None yet
Milestone
No milestone
3 participants
@jlurien @hdamker @maxl2287