-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move "description" out of "allOf" declaration #205
Move "description" out of "allOf" declaration #205
Conversation
If there is a way to add it to v0.9.0 it would be quite good. |
@maxl2287 Please see comment in the issue. Also, many of these AllOf statements were added specifically for the description and could be removed if we were to remove the description from the AllOf. |
@RandyLevensalor @maxl2287 have you tested or can you test that the behavior of editors and tooling is then still the expected one? I thought that we needed the |
It works well with both Redoc and Swagger viewers. The aim of the "allOf" was to avoid having $ref as property at same level of description, but with the workaround, this is avoided. |
Hi @maxl2287 I think you need to rebase this PR, as github is reporting a conflict. Can you do that? Thanks. |
9d2c121
to
84d7b89
Compare
Yep, done. |
What type of PR is this?
What this PR does / why we need it:
We are currently discovering that by using an openapi generator the current version 0.9.0 of QoD causes problems by having the "description" inside of "allOf"-declaration
Which issue(s) this PR fixes:
Fixes #204