Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue_194_PR #217

Closed
wants to merge 6 commits into from
Closed

issue_194_PR #217

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
acae564
issue_194_PR
SyeddR Sep 8, 2023
df7ba57
updated application Id
SyeddR Oct 16, 2023
ee8fda1
removed empty line 436
SyeddR Oct 25, 2023
f798b86
Update qod-api.yaml ApplicationServer schema description
eric-murray Oct 26, 2023
60f0ceb
Merge branch 'main' into issue_194_slide_deck
eric-murray Oct 31, 2023
f0b5adf
Update qod-api.yaml
eric-murray Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions code/API_definitions/qod-api.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,7 @@ components:
description: Attributes required to create a session
type: object
properties:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the blank line here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed it.

duration:
description: |
Session duration in seconds. Maximal value of 24 hours is used if not set.
Expand Down Expand Up @@ -866,6 +867,12 @@ components:
* `ipv6Address`
type: object
properties:
applicationId:
description: |
A public identifier that uniquely identifies the application initiating a QoS session. The applicationId is more granular than the clientId, which identifies the unique customer. A client or customer could have one or more applications that need to be tracked. The Id is systematically relayed to downstream systems, including but not limited to, the Network Exposure Function (NEF) and the Policy Control Function (PCF) within the 5G framework.
The primary utility of this transmission is to facilitate the application of relevant policies, ensuring that the application is appropriately tagged within usage records.
type: string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we some constraints on the string size and values?
minLength: 3
maxLength: 256 (default value)
pattern: (should we exclude strings like "??? or ***"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SyeddR any response to this?

example: XRapp123
ipv4Address:
$ref: "#/components/schemas/Ipv4Address"
ipv6Address:
Expand Down