Align event notification with CloudEvents spec #224
Conversation
jlurien
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
|
The last commit is about a month ago here. Does it mean that we are ready here? ... Guess that we need your reviews @jlurien @eric-murray @RandyLevensalor @akoshunyadi |
PR is mine so I cannot review it myself, but yes, we need this to be reviewed, it is an important change. I would add @bigludo7 as reviewer here as he is in charge of this same tasks in other subprojects. |
- Added data to CloudEvents base class - Notification example moved to callback
- Move QoS status changed event example to components, to be aligned with template in Commonalities
added eol at the end of the file to suit linting
removing trailing spaces
…thub.com/jlurien/QualityOnDemand into feat/align-notifications-with-guidelines
|
@bigludo7 @eric-murray @akoshunyadi @RandyLevensalor @akoshunyadi : there are no new comments since last week. Are we good to go to merge today? |
|
@hdamker I think this is ready to be merged. Thanks for all comments and feedback |
What type of PR is this?
What this PR does / why we need it:
Align QoD event notification with recently approved guidelines adhering to CloudEvents specification
Which issue(s) this PR fixes:
Fixes #221
Changelog input