Add error 429 QUOTA_EXCEEDED #297
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlurien
requested review from
hdamker,
eric-murray and
RandyLevensalor
as code owners
|
This PR is no longer necessary as it was incorporated into #306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Adds a new error scenario to be used when a server logic rejects a request to create a session due to a business quota being exceeded.
Added a subcase for 429 with a new specific code QUOTA_EXCEEDED
Which issue(s) this PR fixes:
Fixes #257
Special notes for reviewers:
403 could have been used instead, as a general forbidden due to business rules, but 429 is more related to cases where rate or quota limits are exceeded. But this could be open to debate as guidelines are not explicit about this case. It is related with the discussion for Commonalities PR camaraproject/Commonalities#213
Changelog input